Unable to retrieve deployment info if helm release name is templated #836
Labels
Comments
|
@johnmshields are you interested in sending a PR for this? |
|
Sure, I'd be happy to... just haven't gone through any of the CLA stuff, yet. I'll put that together ASAP. |
johnmshields
added a commit
to johnmshields/skaffold
that referenced
this issue
Jul 26, 2018
The helm release name can be templated so within the `deployRelease` function the `releaseName` variable should be used any time the release name is desired. This commit updates the final call to `getDeployResults` to properly use the `releaseName` variable.
dgageot
added a commit
that referenced
this issue
Jul 26, 2018
Issue #836: Use releaseName to get release info.
|
Fixed with #855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
A helm deployment should retrieve the deployment information after deployment and does not return a warning.
Actual behavior
The deployment information is not retrieved and a warning is displayed when the release name includes a templated value.
WARN[0035] error retrieving helm deployment info: Error: invalid release name, must match regex ^(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])+$ and the length must not longer than 53The warning above occurs due to the code here using
r.Nameinstead ofreleaseNamefrom here.So line 239 should be changed from:
to
The text was updated successfully, but these errors were encountered: