-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IMAGE_REPO, IMAGE_NAME, IMAGE_TAG available in build.artifacts[i].docker.buildArgs #4295
Labels
kind/bug
Something isn't working
priority/p3
agreed that this would be good to have, but no one is available at the moment.
Comments
This was referenced Jun 6, 2020
@javier-b-perez Unfortunately the pr #3974 linked in #3229 only added the We need to do similar thing for docker builder here |
gsquared94
added
priority/p3
agreed that this would be good to have, but no one is available at the moment.
and removed
priority/p2
May take a couple of releases
labels
Sep 14, 2020
0xADD1E
added a commit
to 0xADD1E/skaffold
that referenced
this issue
Aug 19, 2022
Resolves GoogleContainerTools#4295 Docs have long stated that these fields are available when using the local docker builder, now they actually are.
0xADD1E
added a commit
to 0xADD1E/skaffold
that referenced
this issue
Aug 24, 2022
Resolves GoogleContainerTools#4295 Docs have long stated that these fields are available when using the local docker builder, now they actually are.
aaron-prindle
pushed a commit
that referenced
this issue
Aug 30, 2022
* fix: Fill IMAGE_TAG,etc on Docker builds Resolves #4295 Docs have long stated that these fields are available when using the local docker builder, now they actually are. * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Something isn't working
priority/p3
agreed that this would be good to have, but no one is available at the moment.
Expected behavior
Actual behavior
Information
Steps to reproduce the behavior
git clone https://github.com/javier-b-perez/skaffold-tags-demo.git
skaffold build --default-repo=gcr.io/my-project -t demo
Workaround
The text was updated successfully, but these errors were encountered: