Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: nit
Browse files Browse the repository at this point in the history
ericzzzzzzz committed Feb 8, 2023
1 parent 386fd54 commit ced8397
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion pkg/skaffold/render/renderer/kustomize/kustomize.go
Original file line number Diff line number Diff line change
@@ -286,7 +286,6 @@ func (k Kustomize) mirrorFile(kusDir string, fs TmpFS, path string) error {
if sUtil.IsURL(path) {
return nil
}
// todo making everything absolute path
pFile := filepath.Join(kusDir, path)
bytes, err := ioutil.ReadFile(pFile)
if err != nil {
4 changes: 1 addition & 3 deletions pkg/skaffold/render/renderer/util/util.go
Original file line number Diff line number Diff line change
@@ -68,9 +68,7 @@ func BaseTransform(ctx context.Context, manifests manifest.ManifestList, builds
if manifests, err = manifests.SetLabels(labels, manifest.NewResourceSelectorLabels(opts.TransformAllowList, opts.TransformDenylist)); err != nil {
return manifests, err
}
// This is kind of strange, it seems to indicate namespace setting is controlled by this offline flag. If a user set namespace through command line, the command line setting should always be honored
// regardless of the offline flag. The offline flag should be used to indicate if users want to use information from their current connected cluster for skaffold actions, the information can be namespace, context(can be used
// to determine cluster platforms) or something else.

if !opts.Offline {
if manifests, err = manifests.SetNamespace(ns, rs); err != nil {
return manifests, err

0 comments on commit ced8397

Please sign in to comment.