Skip to content

Commit

Permalink
add test
Browse files Browse the repository at this point in the history
  • Loading branch information
alphanota committed Jan 17, 2025
1 parent d52f744 commit 8f7960a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ jobs:
minikube_version: [1.34.0]
gcloud_sdk_version: [502.0.0]
container_structure_tests_version: [1.19.3]
java: [21]
integration_test_partitions: [0, 1, 2, 3]
steps:

- name: Check out code into the Go module directory
Expand Down Expand Up @@ -137,4 +135,5 @@ jobs:
run: |
cd integration/testdata/docker-run-with-build-args
skaffold config set --global collect-metrics false
skaffold run --tail
skaffold build --cache-artifacts=false --verbosity=debug
docker run child:latest
3 changes: 2 additions & 1 deletion integration/build_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,8 @@ func TestRunWithDockerAndBuildArgs(t *testing.T) {
for _, test := range tests {
testutil.Run(t, test.description, func(t *testutil.T) {

Check failure on line 348 in integration/build_test.go

View workflow job for this annotation

GitHub Actions / PR linters, checks

unnecessary leading newline (whitespace)

skaffold.Build().InDir(test.projectDir).Run(t.T)
ns, _ := DefaultNamespace(t.T)
skaffold.Build().InNs(ns.Name).InDir(test.projectDir).Run(t.T)

defer skaffold.Delete().InDir(test.projectDir).Run(t.T)
expected := "IMAGE_REPO: gcr.io/k8s-skaffold, IMAGE_NAME: skaffold, IMAGE_TAG:latest"
Expand Down

0 comments on commit 8f7960a

Please sign in to comment.