Skip to content

Commit

Permalink
fix: stderr of "helm template" not printed
Browse files Browse the repository at this point in the history
Without stderr is hard to tell why template rendering fails
  • Loading branch information
michelesr committed Oct 26, 2022
1 parent bef0268 commit 8b33d89
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/skaffold/render/renderer/helm/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func (h Helm) generateHelmManifests(ctx context.Context, builds []graph.Artifact
outBuffer := new(bytes.Buffer)
errBuffer := new(bytes.Buffer)
if err := helm.ExecWithStdoutAndStderr(ctx, h, outBuffer, errBuffer, false, helmEnv, args...); err != nil {
return nil, helm.UserErr("std out err", fmt.Errorf(outBuffer.String()))
return nil, helm.UserErr("std out err", fmt.Errorf(outBuffer.String(), fmt.Errorf(errBuffer.String())))
}
log.Entry(ctx).Errorf(errBuffer.String())
renderedManifests.Append(outBuffer.Bytes())
Expand Down

0 comments on commit 8b33d89

Please sign in to comment.