review nits

GoogleContainerTools · Oct 17, 2018 · 709fd4f · 709fd4f
1 parent 6e295be
commit 709fd4f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/skaffold/build/local/jib_maven.go b/pkg/skaffold/build/local/jib_maven.go
@@ -73,7 +73,7 @@ func generateMavenArgs(goal string, skaffoldImage string, a *latest.JibMavenArti
 		// single-module project
 		command = []string{"--non-recursive", "prepare-package", "jib:" + goal}
 	} else {
-		// multi-module project: we assume `package` is boujd to `jib:<goal>`
+		// multi-module project: we assume `package` is bound to `jib:<goal>`
 		command = []string{"--projects", a.Module, "--also-make", "package"}
 	}
 	command = append(command, "-Dimage="+skaffoldImage)

diff --git a/pkg/skaffold/build/local/jib_test.go b/pkg/skaffold/build/local/jib_test.go
@@ -50,7 +50,7 @@ func TestMavenVerifyJibPackageGoal(t *testing.T) {
 		shouldError  bool
 	}{
 		{"xxx", "", true},   // no goals should fail
-		{"xxx", "\n", true}, // no goals should faill; newline stripped
+		{"xxx", "\n", true}, // no goals should fail; newline stripped
 		{"dockerBuild", "dockerBuild", false},
 		{"dockerBuild", "dockerBuild\n", false}, // newline stripped
 		{"dockerBuild", "build\n", true},
@@ -64,7 +64,7 @@ func TestMavenVerifyJibPackageGoal(t *testing.T) {
 	for _, tt := range testCases {
 		util.DefaultExecCommand = testutil.NewFakeCmdOut("mvn --quiet --projects module jib:_skaffold-package-goals", tt.mavenOutput, nil)
 
-		err := verifyJibPackageGoal(context.TODO(), tt.requiredGoal, ".", &latest.JibMavenArtifact{Module: "module"})
+		err := verifyJibPackageGoal(context.Background(), tt.requiredGoal, ".", &latest.JibMavenArtifact{Module: "module"})
 		if hasError := err != nil; tt.shouldError != hasError {
 			t.Error("Unexpected return result")
 		}