fix: auto-setting lock attribute on deb_index #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three bugs: - Need to check which WORKSPACE/WORKSPACE.bazel file to update - Under bzlmod, printed the canonical name (with a bunch of tilde) rather than apparent name of the rule - Missed escaping for quotes, so the command we printed for users to run had too many arguments
thesayyn
approved these changes
Jul 17, 2024
| @@ -17,15 +17,33 @@ echo '' | |||
| echo 'Writing lockfile to {workspace_relative_path}' | |||
| cp $lock {workspace_relative_path} | |||
|
|
|||
| # Detect which file we wish the user to edit | |||
| if [ -e $BUILD_WORKSPACE_DIRECTORY/WORKSPACE ]; then | |||
There was a problem hiding this comment.
looks like we should also support MODULE.bazel here.
There was a problem hiding this comment.
yes, will file a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three bugs:
Also as a convenience, check if the user setup
tools/buildozerso we don't rely on the $PATH if we can help it.