Bzlmod support #50
Merged
Bzlmod support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, it looks close, I'll take a look next week. |
thesayyn
reviewed
Jun 12, 2024
|
Those tests are now combined, I had to delete the WORKSPACE.bzlmod file in e2e/smoke because it seems that the dependencies of rules_distroless are managed by the MODULE.bzl, so with that WORKSPACE.bzlmod file it would complain that it could not find certain dependencies (e.g. rules_oci) |
jacobshirley
commented
Jun 15, 2024
Comment on lines
+55
to
+64
| # Get the package name with either bzlmod enabled or disabled | ||
| package_name = rctx.attr.name.split("~")[-1] | ||
|
|
||
| package_defs = [ | ||
| '"""Generated by rules_distroless. DO NOT EDIT."""', | ||
| """load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")""", | ||
| "", | ||
| "", | ||
| "# buildifier: disable=function-docstring", | ||
| "def {}_packages():".format(rctx.attr.name), | ||
| "def {}_packages():".format(package_name), |
There was a problem hiding this comment.
I also had to get the last component of the path, as otherwise it would put ~ in the function name and then error: syntax error at '~': expected (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I'm not sure if this is the best-practice way to implement bzlmod, but it does seem to work. Any feedback welcome. I've created a test for it in e2e/ so that the MODULE.bazel is different to the root one like the examples/ have; but I can move to examples/ if that would be better.