feat: update flatten to deduplicate files #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently implemented, this option does not deduplicate files, which means the duplicate file path errors can still occur in some cases. This change updates `flatten.sh` to deduplicate files as well, with the final file in the archive being preserved for each path. It also renames `assert_tar_listing` to `assert_tar_mtree` and creates a new `assert_tar_listing` rule that lists archive contents instead of exporting an mtree.
3275814 to
0b84ccc
Compare
thesayyn
reviewed
Dec 9, 2024
thesayyn
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119 added a deduplicate option to
flattento address "duplicates of file paths not supported" errors when loading flattened images with Docker.This option deduplicates directories, but in its current implementation it does not deduplicate files. This means the duplicate file path errors can still occur in some cases.
This change updates
flatten.shto deduplicate files as well, with the final file in the archive being preserved for each path.It also renames
assert_tar_listingtoassert_tar_mtreeand creates a newassert_tar_listingrule that lists archive contents instead of exporting an mtree.