-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http support for git repository context #1196
Conversation
usage: set the GIT_PULL_METHOD env var to http or https for starting the container
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
func getGitPullMethod() string { | ||
gitPullMethod := os.Getenv(gitPullMethodEnvKey) | ||
if ok := supportedGitPullMethods[gitPullMethod]; !ok { | ||
gitPullMethod = gitPullMethodHTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitPullMethod = gitPullMethodHTTPS | |
return gitPullMethodHTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tejal29 for your suggestion, you may commit that.
Thanks @yw-liu for your PR. |
Description
In developing or testing environment, add http support for Git Repository context would be helpful.
Usage: set the GIT_PULL_METHOD env var to http or https when starting the container.