Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests break flags in go 1.13 #950

Closed
cvgw opened this issue Jan 3, 2020 · 0 comments
Closed

Integration tests break flags in go 1.13 #950

cvgw opened this issue Jan 3, 2020 · 0 comments
Assignees
Labels
area/testing Issues related to testing kaniko itself kind/bug Something isn't working

Comments

@cvgw
Copy link
Contributor

cvgw commented Jan 3, 2020

Actual behavior
Testing flags are overwritten by flags in integration_test.go

flag provided but not defined: -test.testlogfile

Expected behavior
Testing flags are not overwritten

To Reproduce
Steps to reproduce the behavior:

  1. use golang 1.13
  2. Execute a single integration test

Triage Notes for the Maintainers

Description Yes/No
Please check if this a new feature you are proposing
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
Please check if your dockerfile is a multistage dockerfile
@cvgw cvgw added kind/bug Something isn't working area/testing Issues related to testing kaniko itself labels Jan 3, 2020
@samos123 samos123 self-assigned this Jan 7, 2020
@tejal29 tejal29 closed this as completed in fa94f6b Jan 8, 2020
tejal29 added a commit that referenced this issue Jan 8, 2020
Fixes #950 integration test failing on go 1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues related to testing kaniko itself kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants