Update CONTRIBUTING guidelines #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/323273546
|
Can you please add the same paragraph to issue/PR template? See step 3 in the execution plan. |
|
Good point, I missed this. Added the instructions to the issues and PR templates as well. |
blakeli0
reviewed
Mar 7, 2024
| @@ -1,14 +1,10 @@ | |||
| Thank you for your interest in contributing! For general guidelines, please refer to | |||
| the [contributing guide](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md). | |||
|
|
|||
| Before filing a pull request, make sure to do the following: | |||
|
|
|||
| - [ ] Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose. | |||
There was a problem hiding this comment.
I think these checkboxes are still very valid, can we keep them? I know people are not really following them right now but it still helps.
There was a problem hiding this comment.
Yup! I've included a combination of what we had before (with verification of integration tests and checkstyle) and some of the new content.
blakeli0
approved these changes
Mar 14, 2024
mpeddada1
added a commit
to GoogleContainerTools/jib-extensions
that referenced
this pull request
Apr 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/323273546