This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
running tests through gcloud #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* explicitly specifying a debian mirror for debootstrap * use the actual correct mirror * variables are important * fixing comments * Switch to envsubst from sed.
nkubala
reviewed
Sep 23, 2016
| fi | ||
|
|
||
| if [ "$VERSION" == "jessie" ] |
There was a problem hiding this comment.
just for my own understanding: why take version as a parameter at all if we only support building jessie? are we planning on supporting wheezy (or other versions) in the future?
There was a problem hiding this comment.
It's to support different versions in the future as they get rolled out. We need to support as many as three versions at a time. We'll get rid of EOLed versions from the if statement as they're deprecated.
dlorenc
approved these changes
Sep 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dlorenc