Add a git hook to run tests, and instructions. (#104)

* Add a git hook to run tests, and instructions.

* Buildifier to fix hook.

* Remove redundant shellcheck.

.travis.yml

@@ -26,5 +26,4 @@ install:
   - go get -u github.com/bazelbuild/buildifier/buildifier
 
 script:
- - find . -name "*.sh" | grep -v "third_party/" | xargs shellcheck
  - make test

CONTRIB.md

@@ -1,3 +1,13 @@
+# Environment Setup
+
+To build and test these images you will need to install `bazel`.
+
+To install a pre-commit hook that will automatically run tests, run the following command:
+
+```shell
+ln -s $(pwd)/hack/hooks/* .git/hooks/
+```
+
 # How to build these base images
 
 We use `bazel` to build most of the images in this repository, so that we can build them reproducibly.

check-fmt.sh

@@ -1,13 +1,22 @@
 #!/bin/bash
+set -ex
+
 echo "Checking gofmt..."
 files=$(gofmt -l -s ./tests)
 if [[ $files ]]; then
     echo "Gofmt errors in files: $files"
     exit 1
 fi
-echo "Checking go vet..."
-files=$(go vet ./tests)
+
+echo "Checking buildifer..."
+# shellcheck disable=SC2046
+files=$(buildifier -mode=check $(find . -not -path "./vendor/*" -name 'BUILD' -o -name '*.bzl' -type f))
 if [[ $files ]]; then
-   echo "Go vet errors in files: $files"
-   exit 1
+    echo "$files"
+    echo "Run 'buildifier -mode fix \$(find . -name BUILD -o -name '*.bzl' -type f)' to fix formatting"
+    exit 1
 fi
+
+
+echo "Checking shellcheck..."
+find . -name "*.sh" | grep -v "third_party/" | xargs shellcheck

hack/hooks/pre-commit

@@ -0,0 +1,2 @@
+#!/bin/bash
+make test

reproducible/ubuntu/BUILD

@@ -8,7 +8,7 @@ UBUNTU_ENV = {
 
 NODEJS_ENV = {
     "PORT": "8080",
-    "NODE_ENV": "production"
+    "NODE_ENV": "production",
 }
 
 docker_build(
@@ -39,9 +39,9 @@ docker_build(
     base = "//reproducible/ubuntu:ubuntu",
     env = NODEJS_ENV,
     ports = ["8080"],
-    tars =[
-        "//reproducible/ubuntu:nodejs"
-    ]
+    tars = [
+        "//reproducible/ubuntu:nodejs",
+    ],
 )
 
 # nodejs_ubuntu_build is a docker image that is a nodejs install compiled from
@@ -50,9 +50,9 @@ docker_build(
     name = "nodejs_ubuntu_build",
     base = ":ubuntu_build",
     env = NODEJS_ENV,
-    tars =[
-        "//reproducible/ubuntu:nodejs"
-    ]
+    tars = [
+        "//reproducible/ubuntu:nodejs",
+    ],
 )
 
 # nodejs_builder is a docker image that is capable of building nodejs running
@@ -65,6 +65,6 @@ docker_build(
     ],
     files = [
         ":mknodeimage.sh",
-        "@nodejs_tar_download//file"
-        ],
+        "@nodejs_tar_download//file",
+    ],
 )