This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Add new fields within deidentify_config field of google_data_loss_prevention_deidentify_template resource
#1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevention_deidentify_template` resource (#6872) * Start adding `recordTransformations` field, make mutually exclusive with `infoTypeTransformations` This stops `infoTypeTransformations` being required - not a breaking change? * Add `recordTransformationsfieldTransformations.fields.*` fields * Add `recordTransformationsfieldTransformations.condition.*` fields and validation Note: this is a repeat of something already in the file but they differ by use of `exactly_one_of`. * Add `recordTransformations.fieldTransformations.primitiveTransformation.replaceConfig.*` fields and validation * Add `recordTransformations.fieldTransformations.primitiveTransformation.redactConfig.*` fields * Make 'values' fields in `confitions` and `replaceConfig` fields both have exactly_one_of restrictions and same descriptions * Add comments about `exactly_one_of` entries that are yet to be implemented * Fix mistake - `redactConfig` is meant to be an empty object, attribute properties in yaml to `characterMaskConfig` field instead * Update existing DeidentifyTemplate tests to reflect use of `infoTypeTransformations` field * Add new DeidentifyTemplate test that uses implemented `recordTransformations` fields * Fix unclosed strings in acceptance test * Fix error in generating `exactly_one_of` entries * Fix error where `fieldTransformations` should be an array, remove incompatible use of `exactly_one_of` A bug in the SDK means that `exactly_one_of` doesn't work with fields nested within arrays * Refactor and rename tests * go fmt * Update test name to allow multiple tests that set `recordTransformations` * Allow empty `redactConfig` object to be sent to API * Add acceptance test for use of `redactConfig` transformation * Update `replaceConfig` config test to add a second condition To check for any reordering by the API * Add acceptance test for use of `characterMaskConfig` transformation * go fmt * MAke `primitiveTransformation` a required field * Remove ineffective `exactly_one_of` blocks These currently create empty ExactlyOneOf lists in the downstream * Update descriptions for `redactConfig`, `characterMaskConfig` * Refactor acceptance tests into single `recordTransformations` test Tests `replace_config`, `redact_config` and `character_mask_config` * Update docs after feedback * Add missing validation for `replace_config.new_value` fields * Update acc tests to include removal of blocks Test removal of field_transformations, conditions * Update docs to show that primitive_transformation is a union field * Update mmv1/products/dlp/api.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/dlp/api.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of hashicorp/terraform-provider-google#9836
This PR adds more fields to the
google_data_loss_prevention_deidentify_templateresource [provider docs] under the (already implemented)deidentify_configfield [API docs].The
deidentifyConfig.infoTypeTransformations.*fields are already in the resource.This PR adds:
deidentifyConfig.recordTransformations.fieldTransformations, and these subfields within:fields.*- all subfieldscondition.*- all subfieldsprimitiveTransformation.replaceConfigprimitiveTransformation.redactConfigprimitiveTransformation.characterMaskConfigI'm going to add more
primitiveTransformationsubfields in future but I wanted to keep the PR size small.List
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6872