Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add secret manager module and sample it tests to native image CI #2206

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Sep 28, 2023

Changes in this pr:

  • Add secret manager sample app test to native test ci. Tests run for sample application:
com.example.SecretManagerSampleIntegrationTests > testDeleteSecret() SUCCESSFUL

com.example.SecretManagerSampleIntegrationTests > testCreateReadSecret() SUCCESSFUL

com.example.SecretManagerSampleIntegrationTests > testApplicationStartup() SUCCESSFUL
  • Add secret manager module it test to native test ci.
    tests run for module:
com.google.cloud.spring.secretmanager.it.SecretManagerTemplateIntegrationTests > testReadWriteSecrets() SUCCESSFUL

com.google.cloud.spring.secretmanager.it.SecretManagerTemplateIntegrationTests > testUpdateSecrets() SUCCESSFUL

com.google.cloud.spring.secretmanager.it.SecretManagerTemplateIntegrationTests > testReadMissingSecret() SUCCESSFUL
  • Test resource uniqueness for parallel runs :
    • Module test: add uuid to secret used.
    • Sample test: refactor into 2 separate tests.
      • SecretManagerSampleLoadSecretsIntegrationTests tests for sample application load, which load secrets as properties into the application context; This test uses one pre-created secret in ci, read-only.
      • SecretManagerSampleTemplateIntegrationTests tests for SecretManagerTemplate operations in sample application. This test now creates and deletes unique secrets for each run.

@zhumin8 zhumin8 marked this pull request as ready for review October 2, 2023 15:00
@zhumin8 zhumin8 requested a review from a team as a code owner October 2, 2023 15:00
Copy link
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't intend to review - I mistakenly went over this one when approving deps PRs :)

@mpeddada1
Copy link
Contributor

@zhumin8 Apologies for the additional work! We recently merged the PR to set up sub-jobs for native image checks so as a extra step, we need to add secretmanager-sample here for it to be included in the CI.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants