-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add secret manager module and sample it tests to native image CI #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkedavison
approved these changes
Oct 2, 2023
diegomarquezp
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't intend to review - I mistakenly went over this one when approving deps
PRs :)
burkedavison
approved these changes
Oct 9, 2023
Kudos, SonarCloud Quality Gate passed!
|
zhumin8
added a commit
that referenced
this pull request
Oct 19, 2023
Part of [this comment](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/1e8602dd41e63902b8e4193653d2ce5e68e795d3/spring-cloud-gcp-samples/spring-cloud-gcp-secretmanager-sample/src/test/java/com/example/SecretManagerSampleIntegrationTests.java#L36) was accidentally removed with changes in #2206.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pr:
tests run for module:
SecretManagerSampleLoadSecretsIntegrationTests
tests for sample application load, which load secrets as properties into the application context; This test uses one pre-created secret in ci, read-only.SecretManagerSampleTemplateIntegrationTests
tests forSecretManagerTemplate
operations in sample application. This test now creates and deletes unique secrets for each run.