Migrating "spring-cloud-gcp-storage" tests to Junit5 #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elefeint
suggested changes
Mar 22, 2022
| String location = "gs://test-spring/test"; | ||
| Storage storage = mock(Storage.class); | ||
| when(storage.get(BlobId.of("test-spring", "test"))).thenReturn(null); | ||
|
|
||
| GoogleStorageResource resource = new GoogleStorageResource(storage, location, false); | ||
| resource.getInputStream(); | ||
|
|
||
| assertThatThrownBy(() -> resource.getOutputStream()) |
There was a problem hiding this comment.
resource.getInputStream()
| File testFile = this.temporaryFolder.newFile("benfica"); | ||
| void testNewFiles(@TempDir Path tempDir) throws IOException { | ||
|
|
||
| Path testFileOld = tempDir.resolve("benfica"); |
There was a problem hiding this comment.
Rename testFileOld to testPath to better reflect what it is.
|
Kudos, SonarCloud Quality Gate passed!
|
elefeint
approved these changes
Mar 22, 2022
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…form#1023) * Migrating to JUnit5C * fixing things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests Migrated: