Remove startup pubsub validation #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
zhumin8
approved these changes
Mar 21, 2022
|
I don't think so -- we are just bringing the behavior back to what actuator healthchecks normally do. These healthchecks can be exposed to dashboards, rolling up to Kubernetes liveness (although that's a bad idea because Kubernetes will then restart the pod, which is pointless if there is a connectivity issue to Pub/Sub). |
elefeint
added a commit
that referenced
this pull request
Mar 22, 2022
This was referenced Mar 22, 2022
elefeint
added a commit
that referenced
this pull request
Mar 22, 2022
* remove startup pubsub validation (#1018)
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had failures reported on startup due to startup subscription checking taking too long. While this can be worked around with a longer timeout, actuator healthchecks are a cross-cutting concern that should not prevent application startup.
Fixes #648.