Turn off option to append URLs #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
approved these changes
Mar 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
elefeint
added a commit
that referenced
this pull request
Mar 22, 2022
elefeint
added a commit
that referenced
this pull request
Mar 23, 2022
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, testing maven deploy locally does not generate the child pom XMLs in the same way -- the inherited fields are not populated. So I'd like to merge this in, trigger a staging job, and then verify whether this change works.
If it does not work, I'll back out the property, and hardcode the URL in all deployable modules.