Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading go version to 1.21 #959

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrading go version to 1.21 #959

wants to merge 2 commits into from

Conversation

darshan-sj
Copy link
Collaborator

Upgraded go version to 1.21

Tested:

  1. go get ./...
  2. go mod tidy
  3. built and ran a sharded migration from mysql to spanner and cleaned up the resources.
  4. built and ran a non sharded migration from mysql to spanner and cleaned up the resources.
  5. No errors in the SMT log in all the above steps.

@darshan-sj darshan-sj marked this pull request as ready for review December 15, 2024 10:03
@darshan-sj darshan-sj requested a review from a team as a code owner December 15, 2024 10:03
@darshan-sj darshan-sj requested review from manitgupta, asthamohta and shreyakhajanchi and removed request for a team December 15, 2024 10:03
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.17%. Comparing base (b7ad348) to head (7bf6c80).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #959   +/-   ##
=======================================
  Coverage   46.17%   46.17%           
=======================================
  Files         169      169           
  Lines       22036    22036           
  Branches      515      515           
=======================================
  Hits        10176    10176           
  Misses      11275    11275           
  Partials      585      585           
Components Coverage Δ
backend-apis 45.37% <ø> (ø)
backend-library 52.28% <ø> (ø)
cli 5.05% <ø> (ø)
frontend 33.95% <ø> (ø)

Copy link
Collaborator

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that the version changes are compatible with the kokoro script in SMT GoB repository, ideally it would require to update the version in GoB release script first.
cc: @manitgupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants