Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: filesystem e2e flakiness #8362

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Fix: filesystem e2e flakiness #8362

merged 8 commits into from
Sep 28, 2022

Conversation

rogerthatdev
Copy link
Contributor

Description

Fixes #8294

Checklist

Summary

TLDR: This PR changes cloudbuild.yaml used in run/filesystem/. The goal is to reduce flakiness caused by the initial cloud build timing out waiting for the subsequent cloud build to finish building, pushing, and deploying. It will help centralize troubleshooting for the build associated with this test into one build job instead of 2.

This PR will:

  • in cloudbuild.yaml, replace the gcloud alpha run deploy with 3 separate steps (docker build, docker push, gcloud alpha run deploy).
    • Originally, this single step created a separate build job that build the image, uploaded it to a default Artifact Registry repo, and deployed to Cloud Run in one shot.
  • make it so each build is pushed to the same folder in the cloud-run-source-deploy Artifact Registry repository (cloud-run-source-deploy/filesystem-e2e-test/)
    • Originally, each build was pushed to the cloud-run-source-deploy in its own directory containing one single build.
  • make it so that each build is tagged with the $BUILD_ID
    • Originally, each build was tagged with 'latest` and was isolated from other builds of the same test

Additional details

Note this PR will also change where builds for the filesystem e2e test will be pushed and tagged in the testing project.

Original Artifact Registry organization of filesystem test builds (each build creates a new folder with run service name, tagged latest):

  • Artifact Registry
    • cloud-run-source-deploy
      • filesystem-0f1d81661bac4999b003bfa70d8be988
        • 94b0228ce533:latest
      • filesystem-1cf501e8a6084312aa5a2e4b7e9bfb7c
        • af47b4a4d1c4:latest

New Artifact Registry organization of filesystem test builds (all builds go to same folder and tagged with build ID):

  • Artifact Registry
    • cloud-run-source-deploy
      • filesystem-e2e-test
        • 94b0228ce533:57099b5e-c2fe-47f9-ad66-f4d675ca9fc3
        • af47b4a4d1c4:09a57863-dc21-4809-9c7a-f5bd01078c33

@rogerthatdev rogerthatdev requested review from a team as code owners September 27, 2022 22:28
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 27, 2022
@rogerthatdev rogerthatdev changed the title Fix/filesystem e2e flakiness Fix: filesystem e2e flakiness Sep 27, 2022
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the copyright year (shoudl always stay the same!) But otherwise if Averi's happy I'm happy

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2022
@leahecole leahecole merged commit a18c139 into main Sep 28, 2022
@leahecole leahecole deleted the fix/filesystem-e2e-flakiness branch September 28, 2022 15:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run.filesystem.e2e_test: test_end_to_end failed
5 participants