-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: filesystem e2e flakiness #8362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayside
reviewed
Sep 27, 2022
averikitsch
approved these changes
Sep 28, 2022
leahecole
reviewed
Sep 28, 2022
leahecole
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the copyright year (shoudl always stay the same!) But otherwise if Averi's happy I'm happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8294
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)Summary
TLDR: This PR changes
cloudbuild.yaml
used inrun/filesystem/
. The goal is to reduce flakiness caused by the initial cloud build timing out waiting for the subsequent cloud build to finish building, pushing, and deploying. It will help centralize troubleshooting for the build associated with this test into one build job instead of 2.This PR will:
cloudbuild.yaml
, replace thegcloud alpha run deploy
with 3 separate steps (docker build
,docker push
,gcloud alpha run deploy
).cloud-run-source-deploy
Artifact Registry repository(cloud-run-source-deploy/filesystem-e2e-test/
)cloud-run-source-deploy
in its own directory containing one single build.$BUILD_ID
Additional details
Note this PR will also change where builds for the filesystem e2e test will be pushed and tagged in the testing project.
Original Artifact Registry organization of filesystem test builds (each build creates a new folder with run service name, tagged
latest
):94b0228ce533:latest
af47b4a4d1c4:latest
New Artifact Registry organization of filesystem test builds (all builds go to same folder and tagged with build ID):
94b0228ce533:57099b5e-c2fe-47f9-ad66-f4d675ca9fc3
af47b4a4d1c4:09a57863-dc21-4809-9c7a-f5bd01078c33