Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header checker #8296

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update header checker #8296

merged 1 commit into from
Aug 30, 2022

Conversation

leahecole
Copy link
Collaborator

in anticipation of #8290

@leahecole
Update header checker
dc27745 
in anticipation of #8290
@leahecole leahecole requested a review from a team as a code owner August 30, 2022 18:35
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 30, 2022
@leahecole leahecole mentioned this pull request Aug 30, 2022
Merged
8 tasks
dandhlee
dandhlee approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need to be a separate PR? (just curious)

@leahecole
Copy link
Collaborator Author

@dandhlee I think so - it doesn't seem to work as part of #8290 because I think it runs using whatever is in main

@dandhlee
Copy link
Collaborator

Gotcha. Yuck :(

Admin merging!

@dandhlee dandhlee merged commit ad02dcc into main Aug 30, 2022
@dandhlee dandhlee deleted the header-check-update branch August 30, 2022 18:54
@leahecole
Copy link
Collaborator Author

i'm an idiot, the reason it wasn't working was because I made a typo. Thanks for merging this anyway and good on you for correctly being skeptical 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

Assignees

@vchudnov-g vchudnov-g

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leahecole @dandhlee @vchudnov-g