Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: longer waits to reduce flaky #8288

Merged
merged 2 commits into from
Aug 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def increment_counter(request):
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

return HttpResponse("Deferred counter increment.")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,19 @@ def test_upload_and_view(version):
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ def increment_counter():
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

return "Deferred counter increment."

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,20 @@ def test_upload_and_view(version):
response = requests.get(f"https://{version_hostname}/counter/increment")
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
# counter should be 10 almost immediately. ALMOST immediately
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ def IncrementCounter(environ, start_response):
deferred.defer(do_something_later, my_key, 10)

# Use default URL and queue name, no task name, execute after 10s.
deferred.defer(do_something_later, my_key, 10, _countdown=10)
deferred.defer(do_something_later, my_key, 10, _countdown=20)

# Providing non-default task queue arguments
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=20)
deferred.defer(do_something_later, my_key, 10, _url="/custom/path", _countdown=40)

start_response("200 OK", [("Content-Type", "text/html")])
return ["Deferred counter increment.".encode("utf-8")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,20 @@ def test_upload_and_view(version):
response = requests.get(f"https://{version_hostname}/counter/increment")
assert response.status_code == 200

# counter should be 10 almost immediately
time.sleep(5)
# counter should be 10 almost immediately. ALMOST immediately
time.sleep(10)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "10"

# After 10 seconds, counter should be 20
time.sleep(10)
# After 20 seconds, counter should be 20
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "20"

# After 20 seconds, counter should be 30
time.sleep(10)
# After 40 seconds, counter should be 30
time.sleep(20)
response = requests.get(f"https://{version_hostname}/counter/get")
assert response.status_code == 200
assert response.text == "30"
Expand Down