fix: use backoff exception to gracefully exit and fail #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
reviewed
Aug 12, 2022
| # I was not able to track all the exception types that can be raised from this block | ||
| # of code. | ||
| @backoff.on_exception(backoff.expo, | ||
| Exception, |
There was a problem hiding this comment.
could consider a tuple of multiple exceptions as an alternative to the generic
There was a problem hiding this comment.
Done! Changed to include ones I could find for now, and additional ones could be easily added in the future.
engelke
approved these changes
Aug 15, 2022
|
I think there is some curse on this issue, we're struggling with this for months now 🤣 |
|
It has been a tough one to crack indeed :( |
m-strzelczyk
approved these changes
Aug 16, 2022
|
Tests are expected to fail but admin merging to help tests get unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current retry is making tests fail out. Instead of indefinitely waiting, retrying with a specific number should help determine whether test passes / fails.
Unfortunately I can't get the test to pass, but happy to incorporate ideas to help get this test passing. For now, they no longer will be timing out after ~5 hours, instead they'll fail or pass immediately.
Fixes #8219. Towards #7277.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)