-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example Airflow DAG that sends an email message through SendGrid #7894
Example Airflow DAG that sends an email message through SendGrid #7894
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a unit test - it will likely be very similar to this test
- Should the schedule interval be daily? I can't remember, but is
catchup
set to True by default? If it is, this is going to run a lot when users first add it to their environments. Do you want to highlight having scheduled notifications? If not, consider having it not be scheduled and have the users trigger it as part of the tutorial - Run
nox -s blacken
and I think your whitespace lint errors will be fixed. and If they aren't, please resolve the lint failures - add the dependency to
requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Python.
Description
Example Airflow DAG that sends an email message through SendGrid.
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)