Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Airflow DAG that sends an email message through SendGrid #7894

Merged

Conversation

pavel-salnikov
Copy link
Contributor

Description

Example Airflow DAG that sends an email message through SendGrid.

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 13, 2022
@snippet-bot
Copy link

snippet-bot bot commented May 13, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add a unit test - it will likely be very similar to this test
  2. Should the schedule interval be daily? I can't remember, but is catchup set to True by default? If it is, this is going to run a lot when users first add it to their environments. Do you want to highlight having scheduled notifications? If not, consider having it not be scheduled and have the users trigger it as part of the tutorial
  3. Run nox -s blacken and I think your whitespace lint errors will be fixed. and If they aren't, please resolve the lint failures
  4. add the dependency to requirements.txt

@leahecole leahecole marked this pull request as ready for review August 30, 2022 18:29
@leahecole leahecole requested review from rachael-ds, rafalbiegacz and a team as code owners August 30, 2022 18:29
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Python.

@leahecole leahecole merged commit 0666a6a into GoogleCloudPlatform:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants