Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update noxfile_config.py header year #6558

Merged
merged 5 commits into from
Aug 31, 2021
Merged

chore: Update noxfile_config.py header year #6558

merged 5 commits into from
Aug 31, 2021

Conversation

davidcavazos
Copy link
Contributor

Description

Copying noxfile_config.py with the current year so we don't have to manually change it each time we copy it :)

Checklist

@davidcavazos
Update noxfile_config.py header year
f7d14a9 
Copying noxfile_config.py with the current year so we don't have to manually change it each time we copy it :)
@davidcavazos davidcavazos requested a review from a team as a code owner August 12, 2021 23:27
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@dandhlee
Copy link
Collaborator

I was strictly told by OSPO guidelines to not touch the license header after it gets added.

@JustinBeckwith would you happen to know if we're allowed to change the license header for template files like these?

@JustinBeckwith
Copy link
Contributor

@dandhlee let's talk this one over on monday in chat

@dandhlee
Copy link
Collaborator

Sounds good!

@leahecole leahecole added the status: blocked Resolving the issue is dependent on other work. label Aug 13, 2021
@leahecole
Copy link
Collaborator

Marking as blocked until after Justin and Dan get to chat

@parthea parthea changed the title Update noxfile_config.py header year chore: Update noxfile_config.py header year Aug 14, 2021
@leahecole
Copy link
Collaborator

@dandhlee any updates?

@dandhlee
Copy link
Collaborator

@leahecole going to have our chat soon!

@dandhlee dandhlee assigned dandhlee and unassigned leahecole Aug 16, 2021
@dandhlee dandhlee removed the status: blocked Resolving the issue is dependent on other work. label Aug 18, 2021
dandhlee
dandhlee approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template files are fine :) Got confirmation by the lawyer cat 🐈

@dandhlee dandhlee requested a review from a team August 27, 2021 19:00
@leahecole leahecole merged commit 6d7d39d into master Aug 31, 2021
@leahecole leahecole deleted the update-noxfile-config-year branch August 31, 2021 19:01
@meredithslota meredithslota mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@leahecole leahecole leahecole approved these changes

Assignees

@dandhlee dandhlee

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidcavazos @dandhlee @JustinBeckwith @leahecole