Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency google-cloud-bigquery to v2 #4781

Merged
merged 6 commits into from
Oct 8, 2020
Merged

chore(deps): update dependency google-cloud-bigquery to v2 #4781

merged 6 commits into from
Oct 8, 2020

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 30, 2020 •
edited
Loading

This PR contains the following updates:

Package Update Change
google-cloud-bigquery major ==1.28.0 -> ==2.0.0

Release Notes

googleapis/python-bigquery

v2.0.0

Compare Source

09-30-2020 14:51 PDT

Implementation Changes
  • Transition the library to microgenerator. (#​278)
    This is a breaking change that drops support for Python 2.7 and 3.5 and brings a few other changes.
    See migration guide for more info.
Internal / Testing Changes
  • Update protoc-generated comments (via synth). (#​270)
  • Add CI secrets manager (via synth). (#​271)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from bradmiro and a team as code owners September 30, 2020 23:02
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@kurtisvg kurtisvg assigned shollyman and unassigned kurtisvg Oct 1, 2020
@tswast
Copy link
Contributor

tswast commented Oct 1, 2020

There were some breaking changes, so test failures are not unexpected. Will see if I can push to the renovate-bot branch, otherwise will copy the changes from this PR to a new PR.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 1, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@tswast
Copy link
Contributor

tswast commented Oct 2, 2020

Blocked by googleapis/python-bigquery-pandas#329 -- can't currently have latest google-cloud-bigquery and pandas-gbq in the same environment.

@tswast tswast force-pushed the renovate/google-cloud-bigquery-2.x branch from 9235b84 to 713605b Compare October 5, 2020 21:30
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
tswast
tswast approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass now. Seems like data-cleaning and notebooks don't touch any of the breaking changes from 2.0.

@tswast tswast assigned bradmiro and unassigned tswast and shollyman Oct 6, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@tswast tswast mentioned this pull request Oct 8, 2020
Closed
1 task
@engelke engelke merged commit 48f5ef9 into GoogleCloudPlatform:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradmiro bradmiro bradmiro approved these changes

@tswast tswast tswast approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees

@bradmiro bradmiro

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@renovate-bot @tswast @bradmiro @engelke @shollyman @kokoro-team @kurtisvg