Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add manager for remaining tests #4683

Merged
merged 3 commits into from
Sep 17, 2020
Merged

test: add manager for remaining tests #4683

merged 3 commits into from
Sep 17, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Sep 15, 2020 •
edited
Loading

Re-add manager.py as other sample tests use this for bootstrapping.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 16, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Sep 16, 2020

@busunkim96 Probably it's easier to use the sys.pathhack as it was before, I'm fine with it.

@busunkim96 busunkim96 marked this pull request as ready for review September 17, 2020 15:14
@busunkim96 busunkim96 requested a review from a team as a code owner September 17, 2020 15:14
engelke
engelke approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo tmatsuo merged commit 50f9632 into master Sep 17, 2020
@tmatsuo tmatsuo deleted the iot branch September 17, 2020 16:15
@busunkim96 busunkim96 mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@engelke engelke

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tmatsuo @engelke