fix(translate): fix a broken test #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
approved these changes
Jul 23, 2020
telpirion
approved these changes
Jul 23, 2020
|
Failed Py 3.8 test with 404, but passed the others. Language version should not have mattered. Is it possible that simultaneous running tests interfered with each other? Perhaps name test based on UUID instead of timestamp. |
|
Yeah, I would change the test to use UUID instead of Timestamp. |
|
@engelke Good catch! I didn't notice it's using timestamp. I'll change it to use uuid. |
added 2 commits
July 23, 2020 16:46
busunkim96
pushed a commit
to busunkim96/python-automl
that referenced
this pull request
Aug 17, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Aug 17, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-translate
that referenced
this pull request
Aug 17, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-translate
that referenced
this pull request
Sep 1, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-translate
that referenced
this pull request
Sep 1, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Sep 15, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
busunkim96
pushed a commit
to googleapis/python-automl
that referenced
this pull request
Sep 15, 2020
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
This was referenced Sep 15, 2020
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…n-docs-samples#4360) * fix(translate): fix a broken test fixes #4353 * use uuid * fix builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4353