-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing cloud speech code samples to work with v1beta1 #399
Conversation
This LGTM. I made some small changes for style, can you confirm it still works? |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
This reverts commit bfef34d.
if __name__ == '__main__': | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument('input_uri', type=_gcs_uri) | ||
parser.add_argument('output_uri', type=_gcs_uri) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main point of this sample was to demonstrate having an output uri on gcs (thus '_gcs' in the filename). Is that not supported anymore?
That's not supported any more in v1beta1. I think I also changed the file name to speech_grpc to repurpose it to demo grpc instead. |
This is adapted from alpha samples in speech/api.