Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add main function to attestation verification script #3705

Merged
merged 5 commits into from
May 15, 2020
Merged

Add main function to attestation verification script #3705

merged 5 commits into from
May 15, 2020

Conversation

bkuang
Copy link
Contributor

@bkuang bkuang commented May 7, 2020

fixes #3704

@bkuang bkuang requested a review from a team as a code owner May 7, 2020 18:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2020
tmatsuo
tmatsuo approved these changes May 8, 2020
View reviewed changes
kms/attestations/verify_attestation.py Outdated Show resolved Hide resolved
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented May 15, 2020

Lint failed with W391 blank line at end of file

I'll take a look at the file

@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@tmatsuo tmatsuo merged commit a411ed9 into GoogleCloudPlatform:master May 15, 2020
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
@bkuang
Add main function to attestation verification script [(#3705)](Google…
adcf6b5 
…CloudPlatform/python-docs-samples#3705)

* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
@bkuang @busunkim96
Add main function to attestation verification script [(#3705)](Google…
7e37e98 
…CloudPlatform/python-docs-samples#3705)

* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 16, 2020
@bkuang @busunkim96
Add main function to attestation verification script [(#3705)](Google…
b13924b 
…CloudPlatform/python-docs-samples#3705)

* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@bkuang @busunkim96
Add main function to attestation verification script [(#3705)](#3705)
7ad8154 
* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
@rsamborski rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@bkuang @rsamborski
Add main function to attestation verification script [(#3705)](#3705)
3b58a37 
* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@bkuang @rsamborski
Add main function to attestation verification script [(#3705)](#3705)
5646b13 
* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@bkuang @rsamborski
Add main function to attestation verification script [(#3705)](#3705)
7084ad4 
* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@bkuang @dandhlee
Add main function to attestation verification script [(#3705)](#3705)
84c7bd0 
* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@bkuang @busunkim96
Add main function to attestation verification script [(#3705)](Google…
9699f07 
…CloudPlatform/python-docs-samples#3705)

* Add main function to attestation verification script.

fixes #3704

* Add newline to end of file

* remove a blank line at the end

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@crwilcox crwilcox

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add main function to attestation verification script
7 participants
@bkuang @tmatsuo @busunkim96 @kurtisvg @crwilcox @googlebot @kokoro-team