Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] fix: use a different bucket for requester_pays_test #3655

Merged
merged 4 commits into from
Apr 30, 2020
Merged

[storage] fix: use a different bucket for requester_pays_test #3655

merged 4 commits into from
Apr 30, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 30, 2020 •
edited
Loading

fixes #3654

@frankyn FYI

This PR also has small changes in scripts/decrypt-secrets.sh and scripts/encrypt-secrets.sh to always use sha256 for the digest.

@tmatsuo tmatsuo requested a review from kurtisvg April 30, 2020 19:08
@tmatsuo tmatsuo requested review from crwilcox and a team as code owners April 30, 2020 19:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2020
kurtisvg
kurtisvg suggested changes Apr 30, 2020
View reviewed changes
storage/cloud-client/README_TEST.md Outdated Show resolved Hide resolved
storage/cloud-client/requester_pays_test.py Outdated Show resolved Hide resolved
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 30, 2020

@busunkim96 @kurtisvg Thanks, PTAL

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 30, 2020 •
edited
Loading

@kurtisvg OK, now we have REQUESTER_PAYS_TEST_BUCKET in the secret file. I also updated the decrypt/encrypt scripts to use sha256. We'll see how it works in the Kokoro builds.

PTAL

@tmatsuo tmatsuo merged commit dab08ff into GoogleCloudPlatform:master Apr 30, 2020
@tmatsuo tmatsuo deleted the fix-storage branch April 30, 2020 22:30
tmatsuo pushed a commit that referenced this pull request May 1, 2020
[storage] fix: use a different bucket for requester_pays_test (#3655)
a0e9930 
* [storage] fix: use a different bucket for requester_pays_test

fixes #3654

* rename to README.md, added the envvar to the template

* add REQUESTER_PAYS_TEST_BUCKET env var

* just use REQUESTER_PAYS_TEST_BUCKET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 left review comments

@leahecole leahecole leahecole left review comments

@kurtisvg kurtisvg kurtisvg approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage.cloud-client.requester_pays_test should use a different bucket
5 participants
@tmatsuo @leahecole @busunkim96 @kurtisvg @googlebot