Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to regular flaky in dlp #3328

Closed
wants to merge 4 commits into from
Closed

switch to regular flaky in dlp #3328

wants to merge 4 commits into from

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Apr 10, 2020 •
edited by tmatsuo
Loading

partial fix for #3375

@leahecole leahecole requested a review from a team as a code owner April 10, 2020 17:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@leahecole leahecole changed the title switch to regular flaky switch to regular flaky in dlp Apr 10, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 16, 2020

FYI, there is @pytest.mark.flaky pytest marker, and we should use it.

Anyways, I'm planning to take over the issues around dlp (because there are other issues), so maybe we can close this issue.

tmatsuo
tmatsuo suggested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use @pytest.mark.flaky.

However, I'll open another PR for fixing several issues around dlp, and maybe we can close this issue.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 16, 2020

@leahecole Closing this, but feel free to reopen.

@tmatsuo tmatsuo closed this Apr 16, 2020
@leahecole leahecole deleted the flaky_dlp branch November 10, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo requested changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahecole @tmatsuo @busunkim96 @googlebot