Schedule datastore export #3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to add a |
|
@jlara310 Please add tests |
Acknowledged. Working on adding some unit tests. |
|
@tmatsuo , added unit tests. I'm a bit confused about the new Nox set-up. Do I need to add a noxfile.py for my tests or is it generated for me? |
tmatsuo
reviewed
Apr 9, 2020
|
@GoogleCloudPlatform/python-samples-owners Can we get someone to do a final once-over and merge this for @jlara310 ? |
tmatsuo
approved these changes
Apr 20, 2020
BenWhitehead
approved these changes
Apr 20, 2020
|
Thank you, both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit sample code to update Scheduling Datastore exports documentation to use Cloud Functions and Cloud Scheduler instead of App Engine.