Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactored MP3 file creation test for Hybrid glossaries samples #2379

Merged
merged 3 commits into from
Sep 4, 2019
Merged

fix: refactored MP3 file creation test for Hybrid glossaries samples #2379

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b61bd4b
Merge pull request #1 from GoogleCloudPlatform/master
crowdus Aug 23, 2019
364ea7b
fix: refactored MP3 file creation test
Sep 4, 2019
22c5a91
fix: lint
Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions translate/cloud-client/hybrid_glossaries/hybrid_tutorial_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import filecmp
import os
import sys

Expand Down Expand Up @@ -97,7 +96,6 @@ def test_translate_glossary():

def test_tts_standard(capsys):
outfile = 'resources/test_standard_text.mp3'
expected_outfile = 'resources/expected_standard_text.mp3'
textfile = 'resources/standard_format.txt'

with open(textfile, 'r') as f:
Expand All @@ -107,12 +105,6 @@ def test_tts_standard(capsys):

# Assert audio file generated
assert os.path.isfile(outfile)

# Assert audio file generated correctly
assert filecmp.cmp(outfile,
expected_outfile,
shallow=True)

out, err = capsys.readouterr()

# Assert success message printed
Expand Down