-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner Batch Query Sample #1402
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0137d22
Add intial sample.
kurtisvg 7c3c881
Clean up sample.
kurtisvg cdd7da1
Update license and address style check.
kurtisvg 172ee2c
Replace multiproccessing with concurrent.futures.
kurtisvg bc1ecdb
Update to 1.2.0 and fix threadpool.
kurtisvg 707ec8d
Address feedback.
kurtisvg 092cc88
Downgrade futures to 3.1.0 for python3.
kurtisvg c3b862a
Futures requirement only for python2.
kurtisvg 7bb0eb5
Remove try/catch.
kurtisvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
# Copyright 2018 Google Inc. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""This application demonstrates how to do batch operations using Cloud | ||
Spanner. | ||
|
||
For more information, see the README.rst under /spanner. | ||
""" | ||
|
||
import argparse | ||
import concurrent.futures | ||
import time | ||
|
||
from google.cloud import spanner | ||
|
||
|
||
# [START spanner_batch_client] | ||
def run_batch_query(instance_id, database_id): | ||
"""Runs an example batch query.""" | ||
|
||
# Expected Table Format: | ||
# CREATE TABLE Singers ( | ||
# SingerId INT64 NOT NULL, | ||
# FirstName STRING(1024), | ||
# LastName STRING(1024), | ||
# SingerInfo BYTES(MAX), | ||
# ) PRIMARY KEY (SingerId); | ||
|
||
spanner_client = spanner.Client() | ||
instance = spanner_client.instance(instance_id) | ||
database = instance.database(database_id) | ||
|
||
# Create the batch transaction and generate partitions | ||
snapshot = database.batch_snapshot() | ||
partitions = snapshot.generate_read_batches( | ||
table='Singers', | ||
columns=('SingerId', 'FirstName', 'LastName',), | ||
keyset=spanner.KeySet(all_=True) | ||
) | ||
|
||
# Create a pool of workers for the tasks | ||
start = time.time() | ||
with concurrent.futures.ThreadPoolExecutor() as executor: | ||
futures = [executor.submit(process, snapshot, p) for p in partitions] | ||
|
||
for future in concurrent.futures.as_completed(futures, timeout=3600): | ||
finish, row_ct = future.result() | ||
elapsed = finish - start | ||
print(u'Completed {} rows in {} seconds'.format(row_ct, elapsed)) | ||
|
||
# Clean up | ||
snapshot.close() | ||
|
||
|
||
def process(snapshot, partition): | ||
"""Processes the requests of a query in an separate process.""" | ||
print('Started processing partition.') | ||
try: | ||
row_ct = 0 | ||
for row in snapshot.process_read_batch(partition): | ||
print(u'SingerId: {}, AlbumId: {}, AlbumTitle: {}'.format(*row)) | ||
row_ct += 1 | ||
return time.time(), row_ct | ||
except Exception as e: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would just let the exception bubble up. The executor will print the whole stack trace, this will just print the error message. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
print(e.message) | ||
# [END spanner_batch_client] | ||
|
||
|
||
if __name__ == '__main__': | ||
parser = argparse.ArgumentParser( | ||
description=__doc__, | ||
formatter_class=argparse.RawDescriptionHelpFormatter) | ||
parser.add_argument( | ||
'instance_id', help='Your Cloud Spanner instance ID.') | ||
parser.add_argument( | ||
'database_id', help='Your Cloud Spanner database ID.', | ||
default='example_db') | ||
|
||
args = parser.parse_args() | ||
|
||
run_batch_query(args.instance_id, args.database_id) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
google-cloud-spanner==1.1.0 | ||
google-cloud-spanner==1.2.0 | ||
futures ; python_version < '3' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the definition of the table the sample expects to work on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave a comment that explains that?