Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show entity type name #1062

Merged
merged 3 commits into from
Aug 8, 2017

Conversation

dizcology
Copy link
Member

This PR updates the analyze entities samples to show the names of entity types (as opposed to just the enums).

before:

name            : Golden Gate Bridge
type            : 2

after:

name            : Golden Gate Bridge
type            : LOCATION

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2017
@theacodes
Copy link
Contributor

LGTM, but you need to placate Travis.

@dizcology
Copy link
Member Author

My bad - updated.

@theacodes theacodes merged commit 1df320d into GoogleCloudPlatform:master Aug 8, 2017
busunkim96 pushed a commit to busunkim96/python-language that referenced this pull request May 20, 2020
…es#1062)

* show entity type name

* update v1beta2

* correct indent
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
…es#1062)

* show entity type name

* update v1beta2

* correct indent
busunkim96 pushed a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
…es#1062)

* show entity type name

* update v1beta2

* correct indent
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
* show entity type name

* update v1beta2

* correct indent
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
…es#1062)

* show entity type name

* update v1beta2

* correct indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants