Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video.cloud-client.analyze.video_detect_faces_beta_test: test_detect_faces failed #4794

Closed
flaky-bot bot opened this issue Oct 5, 2020 · 4 comments · Fixed by #4815
Closed

video.cloud-client.analyze.video_detect_faces_beta_test: test_detect_faces failed #4794

flaky-bot bot opened this issue Oct 5, 2020 · 4 comments · Fixed by #4815
Assignees
Labels
api: videointelligence Issues related to the Video Intelligence API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 5, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: d85e2ca
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/workspace/video/cloud-client/analyze/video_detect_faces_beta_test.py", line 33, in test_detect_faces
    assert "Attributes:" in out
AssertionError: assert 'Attributes:' in '\nProcessing video for face detection annotations.\n\nFinished processing.\n\nFace detected:\nFace detected:\nFace de...ted:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\n'
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 5, 2020
@product-auto-label product-auto-label bot added api: videointelligence Issues related to the Video Intelligence API API. samples Issues that are directly related to samples. labels Oct 5, 2020
@danoscarmike
Copy link
Contributor

Reproducing this locally. It's also blocking migration of these samples to googleapis/python-videointelligence (e.g. googleapis/python-videointelligence#51).

I'm wondering if it would be sufficient to assert that the response body is has an annotation result, albeit empty?

@telpirion
Copy link
Contributor

I think that's the right approach, although it makes me a little nervous to say that our service tests don't expect the services to say anything.

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 6, 2020

commit: 85ea173
buildURL: Build Status, Sponge
status: failed

Test output
Traceback (most recent call last):
  File "/workspace/video/cloud-client/analyze/video_detect_faces_beta_test.py", line 33, in test_detect_faces
    assert "Attributes:" in out
AssertionError: assert 'Attributes:' in '\nProcessing video for face detection annotations.\n\nFinished processing.\n\nFace detected:\nFace detected:\nFace de...ted:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\nFace detected:\n'

@danoscarmike
Copy link
Contributor

@telpirion, I hear you. In this case it's not saying nothing - we at least get the "face detected" but it's flaky on whether it returns additional annotations. I'll make a PR.

danoscarmike added a commit that referenced this issue Oct 6, 2020
danoscarmike added a commit that referenced this issue Oct 6, 2020
* chore: fixes flaky test
fixes #4794

* chore: fixes flaky test
Fixes #4793
Removes assertion which the backend inconsistently satifies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: videointelligence Issues related to the Video Intelligence API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants