healthcare.api-client.dicom.dicom_stores_test: test_patch_dicom_store failed

[flaky-bot]

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

---

commit: 41d7204
buildURL: Build Status, Sponge
status: failed

Test output

Traceback (most recent call last):
  File "/tmpfs/src/github/python-docs-samples/healthcare/api-client/dicom/dicom_stores_test.py", line 123, in test_patch_dicom_store
    assert 'Patched DICOM store' in out
AssertionError: assert 'Patched DICOM store' in 'Created DICOM store: test_dicom_store_1589382493\nError, DICOM store not patched: \nDeleted DICOM store: test_dicom_store_1589382493\n'

[gguuss]

Reassigning to Justin, I'm not sure the dicom samples have a proper owner unless it's still Benedict.

[noerog]

Yeah this is caused by a missing permission on the Cloud Healthcare Service Agent service account in IAM.

I added Pub/Sub Publisher to the service account in the test project and will see if that fixes it.

[JustinBeckwith]

@gguuss from a process perspective, whenever you add the appropriate api: <boop> label, it will do the right attribution in sloth to go/yoshi-live would know the OnRamp team is on the hook for it. @tbpg is exploring the idea of blunderbuss style assignment based on API, but it's not there quite yet :) Co-assigned this to @tmatsuo since Python is his area!

[gguuss]

@gguuss from a process perspective, whenever you add the appropriate api: <boop> label, it will do the right attribution in sloth to go/yoshi-live would know the OnRamp team is on the hook for it. @tbpg is exploring the idea of blunderbuss style assignment based on API, but it's not there quite yet :) Co-assigned this to @tmatsuo since Python is his area!

SGTM, thanks for the pointer

[tmatsuo]

I guess our test service account in the test project is the Cloud Healthcare Service Agent. I will add the Pub/Sub publisher role to the service account and run the test locally.

[tmatsuo]

It doesn't. I looked at the test code. It doesn't seem that the test is creating the topic in question.
I'll change it to create the topic and see how it goes.

[tmatsuo]

The test started to pass with the above change. I don't know why it used to pass. Maybe the server side changed?

Anyways, I'll send a PR for this test and also for v1 subdir.

[tmatsuo]

My guess is that, the server changed the behavior and now it checks the existence of the Pub/Sub topic.