Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrape_test: add scrape offset in test scraper to avoid race #119

Merged
merged 1 commit into from
Nov 20, 2023
Merged

scrape_test: add scrape offset in test scraper to avoid race #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scrape/scrape_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,10 @@ func TestScrapeLoopStopBeforeRun(t *testing.T) {
nil,
)

// The loop must terminate during the initial offset if the context
// is canceled.
scraper.offsetDur = time.Hour

// The scrape pool synchronizes on stopping scrape loops. However, new scrape
// loops are started asynchronously. Thus it's possible, that a loop is stopped
// again before having started properly.
Expand Down