Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS insecure skip verify e2e tests #649

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

TheSpiritXIII
Copy link
Member

No description provided.

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-tls-insecure branch 3 times, most recently from ed22d96 to 6a4be38 Compare October 27, 2023 16:29
@pintohutch pintohutch self-assigned this Nov 7, 2023
@bwplotka
Copy link
Collaborator

Nice! From high lvl point of view it looks good. Will do more close review tomorrow 👍🏽

e2e/authorization_test.go Outdated Show resolved Hide resolved
e2e/authorization_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some nits, otherwise LGTM, thanks 👍🏽

e2e/kubeutil/daemonset.go Show resolved Hide resolved
e2e/operatorutil/podmonitoringutil.go Show resolved Hide resolved
e2e/operatorutil/podmonitoringutil.go Outdated Show resolved Hide resolved
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-tls-insecure branch from 6a4be38 to f38a9e5 Compare November 17, 2023 22:07
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-tls-insecure branch from f38a9e5 to 293d83a Compare November 20, 2023 14:26
@TheSpiritXIII TheSpiritXIII merged commit 101a6a8 into main Nov 20, 2023
9 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/e2e-tls-insecure branch November 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants