Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and parallelize target-status ClusterPodMonitoring e2e tests #641

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Add and parallelize target-status ClusterPodMonitoring e2e tests #641

merged 2 commits into from
Oct 20, 2023

Conversation

TheSpiritXIII
Copy link
Member

Additionally this change:

  • Creates generic utilities for checking if a PodMonitoring is started. This will be used in future PRs.
  • Add labels to collectors so that self-scraping tests don't start looking at collectors outside of the current test.

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/e2e-target-status branch from 6460b7c to a36127b Compare October 19, 2023 12:18
@TheSpiritXIII TheSpiritXIII mentioned this pull request Oct 19, 2023
Merged
bwplotka
bwplotka approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very clear code now, thanks!

@bwplotka bwplotka merged commit 2386c12 into main Oct 20, 2023
8 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/e2e-target-status branch October 23, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@bernot-dev bernot-dev Awaiting requested review from bernot-dev

@maxamins maxamins Awaiting requested review from maxamins

Assignees

@bernot-dev bernot-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSpiritXIII @bwplotka @bernot-dev