Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dead letter queue samples #1230

Merged
merged 5 commits into from
Dec 7, 2020

Conversation

jdpedrie
Copy link
Contributor

closes #1178.

@jdpedrie jdpedrie added the api: pubsub Issues related to the Pub/Sub API. label Nov 27, 2020
@jdpedrie jdpedrie requested a review from a team as a code owner November 27, 2020 19:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 27, 2020
@snippet-bot
Copy link

snippet-bot bot commented Nov 27, 2020

Here is the summary of changes.

You added 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 27, 2020
@jdpedrie
Copy link
Contributor Author

jdpedrie commented Dec 3, 2020

Thanks @anguillanneuf. This is fixed!

@anguillanneuf anguillanneuf self-requested a review December 3, 2020 18:47
@bshaffer bshaffer added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
pubsub/api/pubsub.php Outdated Show resolved Hide resolved
pubsub/api/test/DeadLetterPolicyTest.php Outdated Show resolved Hide resolved
@bshaffer bshaffer added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 7, 2020
@anguillanneuf anguillanneuf merged commit 6ff5735 into GoogleCloudPlatform:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pub/Sub: please add DLQ samples for Pub/Sub
4 participants