-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for non-default time zones on Windows #897
Conversation
36602e3
to
5fcd937
Compare
6e5c113
to
0fda09e
Compare
} | ||
ctx, logger, vm := agents.CommonSetup(t, platform) | ||
if _, err := gce.RunRemotely(ctx, logger.ToMainLog(), vm, "", `Set-TimeZone -Id "Eastern Standard Time"`); err != nil { | ||
t.Fatal(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the new windows VM default time zone is just the same as Eastern Time. Does the VM created with zone us-east1 default to have Eastern Time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the default time zone is already Eastern Time then this command is a no-op and the test should still fail as expected.
In my testing the VM time zone was always UTC regardless of which Cloud zone it was created in.
Should we update also ops-agent/integration_test/ops_agent_test.go Lines 837 to 844 in 3ec1e25
|
f69e68f
to
d078974
Compare
d078974
to
f81a91c
Compare
Closing because this has been moved into #1078. |
Description
Add test for non-default time zones on Windows, which is currently broken. When fluent-bit is fixed upstream, merge the fix here and re-run the tests.
Related issues
b/218888265
fluent/fluent-bit#2941
How has this been tested?
Ran tests locally; will let the standard tests run in the PR.
Checklist: