Set non-harmful connection timeout logs to debug level. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log_error flag) and set connection timeout errors to `debug` level.
jkschulz
reviewed
Dec 16, 2021
Co-authored-by: jkschulz <35477443+jkschulz@users.noreply.github.com>
jkschulz
approved these changes
Dec 16, 2021
debug level.|
The presubmit failures were flakes. Manually triggered the integration tests. All passed: https://paste.googleplex.com/5607317325217792. Manually verified that the non-harmful but confusing logs are gone: https://paste.googleplex.com/6255857386913792 Merging. |
rafaelwestphal
pushed a commit
that referenced
this pull request
Dec 20, 2021
braydonk
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for http://b/211011754
Updates Fluent Bit submodule to branch
1.8.11-upstream-connection-timeout-log@ commit324c827, which is just Fluent Bit v1.8.11 (the version we were already at) plus a newnet.connect_timeout_log_errorconfig option, which we will set tofalse(meaningdebuglevel) in our configs to silence these logs until fluent/fluent-bit#4473 is fixed. This new config option is the only diff in the submodule change.Integration tests: http://b/211011754#comment2