Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self_metrics : Write enabled_receivers and feature_tracking metrics to OTLP json. #1882

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

self_metrics : Write enabled_receivers and feature_tracking metrics to OTLP json. #1882

wants to merge 5 commits into from
+120 −8

Conversation

franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Feb 11, 2025 •
edited
Loading

Description

Write enabled_receivers and feature_tracking metrics to OTLP json. This PR doesn't remove the current metric collection from the diagnostics service.

Related issue

b/333412970

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro changed the title [Draft] Write enabled_receivers and feature_tracking metrics to OTLP json. self_metrics : Write enabled_receivers and feature_tracking metrics to OTLP json. Feb 11, 2025
@franciscovalentecastro franciscovalentecastro marked this pull request as ready for review February 11, 2025 21:36
rafaelwestphal
rafaelwestphal reviewed Feb 14, 2025
View reviewed changes
cmd/google_cloud_ops_agent_engine/main.go
@@ -59,6 +60,11 @@ func run() error {
return err
}

err = self_metrics.CollectOpsAgentSelfMetricsToOTLPJSON(ctx, uc, uc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also also add this to the UAP Plugin service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelwestphal rafaelwestphal rafaelwestphal left review comments

@ridwanmsharif ridwanmsharif Awaiting requested review from ridwanmsharif

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscovalentecastro @rafaelwestphal