-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instrumentation quickstart sample #687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 18 18
Lines 703 703
Branches 136 136
=======================================
Hits 687 687
Misses 16 16 ☔ View full report in Codecov by Sentry. |
fcd2774
to
ef19fa3
Compare
d6de111
to
562c3bc
Compare
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
The `opentelemetry_instrumentation_agent_dockerfile` region tag is more general and can be referenced across different languages. I am using the same one for JS in GoogleCloudPlatform/opentelemetry-operations-js#687 I have "pinned" the docs build to existing version to prevent breaking links in the docs.
The `opentelemetry_instrumentation_agent_dockerfile` region tag is more general and can be referenced across different languages. I am using the same one for JS in GoogleCloudPlatform/opentelemetry-operations-js#687 I have "pinned" the docs build to existing version to prevent breaking links in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this set the http.route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: David Ashpole <dashpole@google.com>
This is clone of the existing Go and Java samples. I decided to use Fastify because the instrumentation produces nice traces compared to express, it is popular, and has builtin logging with Pino.
I've excluded the sample from the npm workspace which makes it independent from the rest of the repo instead of a "subpackage".
Output of running it in Cloud Shell: