Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename SDK packages that were changed upstream #329

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Sep 21, 2021

Fixes #314

Upgraded all SDK deps to 0.25.0, including newly renamed packages:

old pkg name new pkg name
@opentelemetry/tracing @opentelemetry/sdk-trace-base
@opentelemetry/node @opentelemetry/sdk-trace-node
@opentelemetry/metrics @opentelemetry/sdk-metrics-base

@aabmass aabmass force-pushed the rename-sdk-packages branch from dbe43b0 to 9af8118 Compare September 21, 2021 21:40
@aabmass aabmass marked this pull request as ready for review September 21, 2021 21:41
@aabmass aabmass requested a review from a team September 21, 2021 21:41
@aabmass aabmass force-pushed the rename-sdk-packages branch from 9af8118 to 7d74bb9 Compare September 21, 2021 21:59
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #329 (9d4bdca) into main (fe89cc2) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d4bdca differs from pull request most recent head 1195d10. Consider uploading reports for the commit 1195d10 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          12       12           
  Lines         421      421           
  Branches       80       80           
=======================================
  Hits          402      402           
  Misses         19       19           
Impacted Files Coverage Δ
...emetry-cloud-monitoring-exporter/src/monitoring.ts 89.47% <ø> (ø)
...lemetry-cloud-monitoring-exporter/src/transform.ts 95.45% <ø> (ø)
...es/opentelemetry-cloud-trace-exporter/src/trace.ts 95.00% <ø> (ø)
...pentelemetry-cloud-trace-exporter/src/transform.ts 98.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe89cc2...1195d10. Read the comment docs.

@aabmass aabmass force-pushed the rename-sdk-packages branch 3 times, most recently from 8ae237b to fd62e1b Compare September 21, 2021 22:16
samples/trace/README.md Outdated Show resolved Hide resolved
@aabmass aabmass force-pushed the rename-sdk-packages branch from fd62e1b to 1195d10 Compare September 24, 2021 17:37
@aabmass aabmass requested review from a team and dashpole September 24, 2021 17:38
@aabmass aabmass merged commit 73f786a into GoogleCloudPlatform:main Sep 27, 2021
@aabmass aabmass deleted the rename-sdk-packages branch September 27, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to renamed sdk packages
2 participants