Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for zone resource detection on GAE standard #341

Merged
merged 1 commit into from
May 8, 2024
Merged

Add test case for zone resource detection on GAE standard #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 43 additions & 19 deletions ...pport/src/test/java/com/google/cloud/opentelemetry/detection/GCPPlatformDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,16 +309,20 @@ public void testGCFResourceWithCloudRunAttributesSucceeds() {
/** Google App Engine Tests * */
@ParameterizedTest
@MethodSource("provideGAEVariantEnvironmentVariable")
public void testGAEResourceWithAppEngineAttributesSucceeds(String gaeEnvironmentVar) {
public void testGAEResourceWithAppEngineAttributesSucceeds(
String gaeEnvironmentVar,
String metadataZone,
String expectedZone,
String metadataRegion,
String expectedRegion) {
envVars.put("GAE_SERVICE", "app-engine-hello");
envVars.put("GAE_VERSION", "app-engine-hello-v1");
envVars.put("GAE_INSTANCE", "app-engine-hello-f236d");
envVars.put("GAE_ENV", gaeEnvironmentVar);

TestUtils.stubEndpoint("/project/project-id", "GAE-pid");
// for standard, the region should be extracted from region attribute
TestUtils.stubEndpoint("/instance/zone", "country-region-zone");
TestUtils.stubEndpoint("/instance/region", "country-region1");
TestUtils.stubEndpoint("/instance/zone", metadataZone);
TestUtils.stubEndpoint("/instance/region", metadataRegion);
TestUtils.stubEndpoint("/instance/id", "GAE-instance-id");

EnvironmentVariables mockEnv = new EnvVarMock(envVars);
Expand All @@ -332,27 +336,47 @@ public void testGAEResourceWithAppEngineAttributesSucceeds(String gaeEnvironment
new GoogleAppEngine(mockEnv, mockMetadataConfig).getAttributes(), detectedAttributes);
assertEquals("GAE-pid", detector.detectPlatform().getProjectId());
assertEquals(5, detectedAttributes.size());

if (gaeEnvironmentVar != null && gaeEnvironmentVar.equals("standard")) {
assertEquals(
"country-region1", detector.detectPlatform().getAttributes().get(GAE_CLOUD_REGION));
} else {
assertEquals(
"country-region", detector.detectPlatform().getAttributes().get(GAE_CLOUD_REGION));
}
assertEquals(expectedRegion, detector.detectPlatform().getAttributes().get(GAE_CLOUD_REGION));
assertEquals("app-engine-hello", detectedAttributes.get(GAE_MODULE_NAME));
assertEquals("app-engine-hello-v1", detectedAttributes.get(GAE_APP_VERSION));
assertEquals("app-engine-hello-f236d", detectedAttributes.get(GAE_INSTANCE_ID));
assertEquals("country-region-zone", detectedAttributes.get(GAE_AVAILABILITY_ZONE));
assertEquals(expectedZone, detectedAttributes.get(GAE_AVAILABILITY_ZONE));
}

// Provides key-value pair of GAE variant environment and the expected region
// value based on the environment variable
private static Arguments gaeTestArguments(
String gaeEnvironmentVar,
String metadataZone,
String expectedZone,
String metadataRegion,
String expectedRegion) {
return Arguments.of(
gaeEnvironmentVar, metadataZone, expectedZone, metadataRegion, expectedRegion);
}

// Provides parameterized arguments for testGAEResourceWithAppEngineAttributesSucceeds
private static Stream<Arguments> provideGAEVariantEnvironmentVariable() {

return Stream.of(
Arguments.of("standard"),
Arguments.of((String) null),
Arguments.of("flex"),
Arguments.of(""));
// GAE standard
gaeTestArguments(
"standard",
// the zone should be extracted from the zone attribute
"projects/233510669999/zones/us15",
"us15",
// the region should be extracted from region attribute
"projects/233510669999/regions/us-central1",
"us-central1"),

// GAE flex
gaeTestArguments(
(String) null,
"country-region-zone",
"country-region-zone",
// the region should be extracted from the zone attribute
"",
"country-region"),
gaeTestArguments(
"flex", "country-region-zone", "country-region-zone", "", "country-region"),
gaeTestArguments("", "country-region-zone", "country-region-zone", "", "country-region"));
}
}
Loading