Add gae auto-configure/auto-instrumentation sample #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
requested changes
May 9, 2023
| @@ -0,0 +1,63 @@ | |||
| Google AppEngine Standard with OTel Auto-instrumentation | |||
| ============================ | |||
| **This sample app is a Maven project and builds separately from the rest of the rest of the examples.** | |||
There was a problem hiding this comment.
Why is it built using Maven? Gradle appears to be supported for AppEngine: https://cloud.google.com/appengine/docs/standard/java-gen2/using-gradle.
examples/gae-autoinstrument-example/src/main/java/com/google/HelloAppEngine.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Please have the build download these binaries rather than checking them into Github.
| ============================ | ||
| **This sample app is a Maven project and builds separately from the rest of the rest of the examples.** | ||
|
|
||
| This example Java app runs on GAE standard environment and is instrumented using OpenTelemetry's [auto-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation) agent. |
There was a problem hiding this comment.
How much of this sample is really specific to AppEngine? Why couldn't one of our other samples be deployed to AppEngine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a stand-alone example that runs OTel Autoinstrumentation, auto-configured to export telemetry to Google Cloud from Google App Engine.